[jdom-interest] Proper way to prune a tree with removeContent
Phill_Perryman at Mitel.COM
Phill_Perryman at Mitel.COM
Wed Nov 9 08:28:25 PST 2005
Bet it was a concurrent modification exception.
If you iterate over a list of three elements and remove the second one
while iterating over it the indexes will get messed up by the ime you get
to the third (in a list which now only has two?)
I am sure I saw a previous article about iterating over the list from size
back to zero so you did not try to access elements that have been removed.
IS Dept, Software Engineer.
phill_perryman at mitel.com
Tel: +44 1291 436023
<Jeff.Rosler at flat
m> <jdom-interest at jdom.org>
Sent by: cc
nces at jdom.org Subject
[jdom-interest] Proper way to prune
a tree with removeContent
I'm running JDOM 1.0 and I just ran into an interesting corruption problem.
In my code, I'm parsing XML elements in a doc and removing specific
elements (branches) based on their attribute values. Please see the code
I initially call this code with profileDOM(null,doc.getRootElement()). It
recursively parses the tree until my checkAttributes() method returns
false. At this point, it removes that element. If it doesn't return false
then it gets the list of children and calls itself (recursion) for each
The problem occurs in the removeContent call. The removeContent correctly
removes the content, but appears to screw up the list. The second time that
removeContent is called with a different parent, it removes the wrong
content node. It appears that the internal list somehow gets screwed up.
While I was debugging this in my IDE, I took a look at the content list in
the parent element and the parent.indexOf(node) was returning the wrong
index for the actual content. In my sample, it returned a text node instead
of an element!
So, two questions ?
If this isn't the correct type of code to prune content, what is? I
remember trying an iterator a while back, but ended up getting some
The second is, isn't this a bug? Is this the right forum to report it?
public void profileDOM(Element parent, Element node) throws Exception
if (parent != null && !checkAttributes(node))
// previously just doing parent.removeContent(node);
int index = parent.indexOf(node);
Content content = parent.removeContent(index);
if (content == null)
logger.info("Removal of element <" + node.getName() + ">
List list = node.getChildren();
Element child = (Element)list.get(i);
// check to see if we should delete child
Flatirons Solutions Corporation
XML and Content Management Solutions
2555 55th Street
Boulder, CO 80301
jeff.rosler at flatironssolutions.com
"The man with a new idea is a crank until the idea succeeds"
To control your jdom-interest membership:
More information about the jdom-interest